New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify SSZ default values #1346
Clarify SSZ default values #1346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could use a few minor changes. Also, this PR would be nice to merge into v.0.8.3
, so I would change the target base before merging.
@c-o-l-o-r Can you please rebase this PR to branch |
f37001b
to
7159e40
Compare
7159e40
to
97347ff
Compare
Thanks @protolambda! I just rebased against |
9586d19
to
b347cf1
Compare
Also, we generally sign commits in the specs repository @c-o-l-o-r (with the exception for commits signed through github, i.e. using the web-interface for merges). |
@protolambda no worries! Sorry for so much back-and-forth -- I will squash into one signed commit! |
b347cf1
to
5523a45
Compare
5523a45
to
3358d70
Compare
Okay great, I have signed my commit. 😄 Let me know if there is anything else I should do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Not entirely sure about the syntax for Union
: type_0
or Union(type_0)
. But that's something to revisit when unions are actually used in practice, the idea is there.
I initially set out to clarify the default value of
Vector
, but felt like this definition would be much clearer in a table format versus a sentence.