filter viable branches in fork choice #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v0.9.2 to master
protolambda
reviewed
Nov 25, 2019
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
djrtwo
changed the title
djrtwo
force-pushed
the
filter-fc-justified
branch
from
5c44117
to
dfcd6f6
Compare
|
Do we merge rm-signing-root first? If so, we should change the signing-roots here to hash-tree-root. |
protolambda
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Small style adjustment, avoid a full state copy.
Also verified that with the unfiltered tree the test fails. But looking forward to more integration-like fork choice tests, unit-testing looks like a poor fit for fork-choice.
Let's update with signing root changes, then merge 👍
|
@djrtwo I think you should change the target branch to |
|
yep nice catch @hwwhww ! |
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
djrtwo
force-pushed
the
filter-fc-justified
branch
from
e87dade
to
e53a6da
Compare
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter for branches that see latest finalized/justified info as correct on-chain before running
get_head.more info here https://notes.ethereum.org/Fj-gVkOSTpOyUx-zkWjuwg?view