Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up GENESIS_FORK_VERSION #764

Closed
wants to merge 1 commit into from
Closed

Clean up GENESIS_FORK_VERSION #764

wants to merge 1 commit into from

Conversation

JustinDrake
Copy link
Collaborator

No description provided.

@djrtwo
Copy link
Contributor

djrtwo commented Mar 12, 2019

I'd rather fork versions be human readable numbers from [0, 2**32) that are converted to 4 byte form in the state. Rather than 4 byte values we have to think about.

@JustinDrake
Copy link
Collaborator Author

We can do GENESIS_FORK_VERSION = int_to_bytes4(i) where i is the human-readable number in [0, 2**32). Minor detail—feel free to close :)

@djrtwo djrtwo closed this Mar 13, 2019
@JustinDrake JustinDrake mentioned this pull request Mar 17, 2019
Merged
@djrtwo djrtwo deleted the JustinDrake-patch-1 branch September 7, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JustinDrake @djrtwo