Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup tests to more easily dump output #839

Merged
merged 1 commit into from Mar 25, 2019
Merged

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Mar 25, 2019

Did a little bit of cleaning of tests to more easily manually output test vectors until we get the CI test gen flow in place. The main change is to ensure that the only required arg for tests is an initial state

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine and fixes things when we don't CI; but once we have CI, I'm inclined to see that we are allowed to use fixtures in conftest.py flexibly. 😇

@djrtwo
Copy link
Contributor Author

djrtwo commented Mar 25, 2019

Agreed. We'll be able to wrap the pytest functions no problem to output vectors when run with pytest --output-yaml or something, and in that case, because the functions will be run in the context of pytest, the fixtures can be used freely.

@djrtwo djrtwo merged commit 7db21e3 into master Mar 25, 2019
djrtwo added a commit that referenced this pull request Mar 25, 2019
backport v0.5.1 bugfixes and #839 into dev
@hwwhww hwwhww deleted the output-sanity-tests branch March 29, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants