Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking outside mobile navigation drawer does not close menu #1850

Closed
wackerow opened this issue Nov 15, 2020 · 0 comments
Closed

Clicking outside mobile navigation drawer does not close menu #1850

wackerow opened this issue Nov 15, 2020 · 0 comments
Labels
bug 🐛 Something isn't working

Comments

@wackerow
Copy link
Member

Describe the bug
The mobile navigation menu is designed to fit 'typical' phones, yet screen sizes slightly larger than this and still below the "mobile screen breakpoint" causes a menu the only fill a portion of the screen. This is fine, but tapping/clicking outside of the menu region does not close the drawer.

To Reproduce
Steps to reproduce the behavior:

(Use something other than phone to test)

  1. Go to 'https://www.ethereum.org/en'
  2. Desktop: Shrink width of window until it changes to mobile nav display at top (or use a standard iPad to demo)
  3. Tap/click hamburger menu to open menu
  4. Tap/click in the background outside of the menu
  5. Menu does not close

Expected behavior
Mobile menu should close when tapping/clicking outside of it on screens that have more space

Screenshots
https://share.getcloudapp.com/WnuronQ6

Additional context
Can take a look at this if you want to assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant