Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo/mispelling in the .es Spanish version of the ethereum.org home page #4877

Closed
A2be opened this issue Dec 22, 2021 · 15 comments
Closed

Typo/mispelling in the .es Spanish version of the ethereum.org home page #4877

A2be opened this issue Dec 22, 2021 · 15 comments
Labels
bug 🐛 Something isn't working

Comments

@A2be
Copy link

A2be commented Dec 22, 2021

Describe the bug

The current word "implulsa" is a typo/misspelling. It is not a word in any language.

The correct word should be "impulsa", as it "powers the Ether cryptocurrency"

This is on line 6 of the page-index.json file.

"page-index-description": "Ethereum es la tecnología de gestión comunitaria que implulsa la criptomoneda ether (ETH) y miles de aplicaciones descentralizadas.",

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. See error in the Ethereum es la tecnología de gestión comunitaria que implulsa la criptomoneda ether (ETH) y miles de aplicaciones descentralizadas.

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Version: [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser: [e.g. stock browser, safari]
  • Version: [e.g. 22]

Additional context

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.

@A2be A2be added the bug 🐛 Something isn't working label Dec 22, 2021
@A2be A2be changed the title Typo/mispelling in the .es Spanish version of Typo/mispelling in the .es Spanish version of the ethereum.org home page Dec 22, 2021
@A2be
Copy link
Author

A2be commented Dec 22, 2021

I'd do the PR if I knew how, but am not sure I have the permissions or know-how to submit it. Happy to learn if someone wants to show me how.

@vluna
Copy link
Contributor

vluna commented Dec 22, 2021

@A2be You can follow this instructions to set up your development environment and create the PR. If you have any questions I will be happy to help you. If you do not want to do it, I can create the PR for you 🙂

@A2be
Copy link
Author

A2be commented Dec 22, 2021

@A2be You can follow this instructions to set up your development environment and create the PR. If you have any questions I will be happy to help you. If you do not want to do it, I can create the PR for you 🙂

Okay, cool. Go ahead and assign the issue to me.

Let's see if I can't get the switches and gears of github moving in such a way to make this simple fix and PR.

@A2be
Copy link
Author

A2be commented Dec 22, 2021

@vluna , I'm thru the initial steps, and up to this one:
Set up your local environment (optional)

  1. If it is "optional", not sure I need all this next bit of complexity. Or do I?
    Question: is it "advisable" for me to do this set of steps?

  2. I use a WinOS computer. I'm not sure how to run commands shown like:
    $ git remote add upstream https://github.com/ethereum/ethereum-org-website.git on a WinOS machine.
    I do know how to use the command line window, and ran DOS stuff a lot back in the 1980s/90s, but those commands look Unix-ish to me, so I'm quite unsure if they'll run in Win, and how I need to set up the directories and permissions to get them to run smoothly on WinOS.

@vluna
Copy link
Contributor

vluna commented Dec 22, 2021

@vluna , I'm thru the initial steps, and up to this one: Set up your local environment (optional)

  1. If it is "optional", not sure I need all this next bit of complexity. Or do I?
    Question: is it "advisable" for me to do this set of steps?
  2. I use a WinOS computer. I'm not sure how to run commands shown like:
    $ git remote add upstream https://github.com/ethereum/ethereum-org-website.git on a WinOS machine.
    I do know how to use the command line window, and ran DOS stuff a lot back in the 1980s/90s, but those commands look Unix-ish to me, so I'm quite unsure if they'll run in Win, and how I need to set up the directories and permissions to get them to run smoothly on WinOS.
  1. I believe you can just skip that, I never set that up and I did not run into any problems.
  2. That is just a regular git command. I do not use windows, but you can use an external bash for it. Or maybe install windows linux subsystem?

@A2be
Copy link
Author

A2be commented Dec 22, 2021

Thanks @vluna . Will skip that entire "optional" step.

But "bash" is not in my vocabulary, so hard to know what is involved, if I wanted to follow your next instruction: " you can use an external bash for it. "

Also, although I've pulled up my fork https://github.com/A2be/ethereum-org-website on a browser tab, I'm not finding how to do the next step, in the section
Make awesome changes!, which is Create new branch for your changes

Where does one do the "create new branch" step?

@vluna
Copy link
Contributor

vluna commented Dec 22, 2021

Thanks @vluna . Will skip that entire "optional" step.

But "bash" is not in my vocabulary, so hard to know what is involved, if I wanted to follow your next instruction: " you can use an external bash for it. "

Also, although I've pulled up my fork https://github.com/A2be/ethereum-org-website on a browser tab, I'm not finding how to do the next step, in the section Make awesome changes!, which is Create new branch for your changes

Where does one do the "create new branch" step?

It means to create a new branch in git for your changes. The sample code is shown below in the step: git checkout -b new_branch_name

@vluna
Copy link
Contributor

vluna commented Dec 26, 2021

Hey @A2be! Were you able to figure it out?

@A2be
Copy link
Author

A2be commented Dec 27, 2021

I've been working at it. Have done
winget ...
and even got some sort of git for WinOS installed,
so I now have Apps I can open called
Git GUI
Git CMD , and
Git Bash (although I still have no idea what "bash" is.

@A2be
Copy link
Author

A2be commented Dec 27, 2021

But I have not been able to figure out how to get all those various cmd line strings that are thrown around operating in my environment.

I probably need to work in a coworking environment for a while, adjacent to an experienced Git and Github person, who is sorta kinda a little bit familiar with WinOS. I need a sherpa.

Given I don't work in or around anyone like that, maybe it is time for me to just give up and let someone else fix that spelling error. :(

@A2be
Copy link
Author

A2be commented Dec 27, 2021

So, bottom line, I still don't know how to run commands shown like:
$ git remote add upstream https://github.com/ethereum/ethereum-org-website.git on my WinOS machine.

@A2be
Copy link
Author

A2be commented Dec 27, 2021

I got a LOT farther when I opened that Git GUI app on WindowsOS.

I might have even got that "git remote add upstream https://github.com/ethereum/ethereum-org-website.git` line to run, after I typed it in following a $ cmd line prompt.

And I could even browse the file I want to update: src/intl/es/page-index.json
where I want to fix the spelling of one word in line 6.

But I could never figure out how to edit just that single line.

And if I did, not sure what would then turn it into a PR on github.

@vluna
Copy link
Contributor

vluna commented Jan 1, 2022

@A2be I have opened the PR for you 🙂

@minimalsm
Copy link
Contributor

Thanks for the report @A2be ❤️ @all-contributors please add @A2be for bug reports

@allcontributors
Copy link
Contributor

@minimalsm

I've put up a pull request to add @A2be! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants