Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect spacing in Card component #8697

Closed
pettinarip opened this issue Nov 21, 2022 · 4 comments
Closed

Incorrect spacing in Card component #8697

pettinarip opened this issue Nov 21, 2022 · 4 comments
Labels
bug 🐛 Something isn't working Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@pettinarip
Copy link
Member

Describe the bug

We tried to fix this issue on a previous PR but it looks like it is not covering correctly all the cases.

To reproduce

  1. Go to https://ethereum.org/en/staking/solo/#why-stake-solo
  2. See incorrect spacing styles

Expected behavior

The 3 cards should not have any spacing between the title and the content of the Card.

Like this:
image

Screenshots

Current styles:
image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

Double check #8132 since it is related to this issue.

@pettinarip pettinarip added the bug 🐛 Something isn't working label Nov 21, 2022
@TylerAPfledderer
Copy link
Contributor

I have a couple of thoughts here! 😄

I'm wondering, because there are components involved that are rendered in the Card via children, maybe they need to apply their own spacing styles versus letting Card do most of the heavy lifting.

Between the two site pages being referenced here and in the related GH Issue, the quick solution I see is to remove justifyContent within Card and apply marginTop: 'auto' to the buttons in the /developers page.

I'm also thinking that on survey of some other pages, that the button could be conditionally rendered within Card. And can have a buttonOptions prop to supply needed props straight to the button.

@armgp armgp mentioned this issue Nov 24, 2022
@armgp
Copy link
Contributor

armgp commented Nov 24, 2022

I just read your comment. I have deleted the justifyContent and now after reading you comment noticed the margin issue for the button and just commited that change also. If there is more to work on the issue than this please take over. @TylerAPfledderer

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 9, 2023
@corwintines
Copy link
Member

Closing as PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

4 participants