Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute CREATE address without RLP library #783

Open
chfast opened this issue Jan 8, 2024 · 1 comment · May be fixed by #815
Open

Compute CREATE address without RLP library #783

chfast opened this issue Jan 8, 2024 · 1 comment · May be fixed by #815
Labels
good first issue Good for newcomers

Comments

@chfast
Copy link
Collaborator

chfast commented Jan 8, 2024

We want to decouple RLP library (mostly used in testing infrastructure and MPT hashing) from the core EVM state modifications. The CREATE address derivation is the only place where RLP is used. For this we only need to implement RLP encoding for uint64.

See the TODO comment at https://github.com/ethereum/evmone/blob/v0.11.0/test/state/host.cpp#L149.

@AbhinavMir
Copy link

AbhinavMir commented Feb 11, 2024

Hi @chfast ! Does the draft PR above look right? I looked at how Aleth used to encode JSON objects and bounced off from there to create a rlp_encode_uint64 function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants