Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't recognise type hints in eth2spec #880

Closed
gurukamath opened this issue Feb 8, 2024 · 1 comment
Closed

CI doesn't recognise type hints in eth2spec #880

gurukamath opened this issue Feb 8, 2024 · 1 comment
Assignees
Labels
C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers

Comments

@gurukamath
Copy link
Collaborator

The eth2spec library was added as a dependency in cancun since the point_evaluation precompile requires some of its functions. However, mypy fails on CI to recognise the type hints from this library even though the py.typed file was recently added to it. See here. We will need to analyse and correct why this is not recognised on CI. As a temporary fix, a type ignore hint has been added. This will have to be removed once a permanent fix is applied.

Note: mypy did not throw any error upon local execution, so it could just be something specific to CI

@gurukamath gurukamath added C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers labels Feb 8, 2024
@gurukamath gurukamath added this to the Post-Cancun Refactoring milestone Feb 8, 2024
@gurukamath gurukamath self-assigned this Feb 8, 2024
@petertdavies
Copy link
Collaborator

Fixed by #885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants