Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/fe cli interface #732

Merged
merged 15 commits into from Jun 15, 2022
Merged

feat/fe cli interface #732

merged 15 commits into from Jun 15, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Jun 3, 2022

Proposal changes

Fe CLI interface
.
Example:

fe create <project-name>
fe check <input> 
fe build <input>

To-Do

  • check for single file
  • check for folders
  • fe create project
  • fe build
  • should run optimize by default
  • clean up message error
  • Add entry to the release notes (may forgo for trivial changes)

Any feel back are welcome!

@vuvoth vuvoth marked this pull request as ready for review June 4, 2022 17:44
@vuvoth
Copy link
Contributor Author

vuvoth commented Jun 7, 2022

Some features in invalid! I will convert it back to daft PR.

@vuvoth vuvoth marked this pull request as draft June 7, 2022 11:14
@vuvoth vuvoth marked this pull request as ready for review June 8, 2022 17:42
@sbillig
Copy link
Collaborator

sbillig commented Jun 9, 2022

Looks great!

I'd prefer that the subcommand names match cargo where possible:

  • fe new foo instead of fe init foo (cargo init initializes a new project in the current directory, which we could also support, but it's less useful than cargo new imo)
  • fe build instead of fe compile. It would also be nice if this (and fe check) operated on the current project if no path is specified.

I'd be happy to merge this as-is, but if you'd like to make some minor changes I'll also suggest some language fixes and rewordings in a followup comment. Thanks @vuvoth!

crates/fe/src/task/check.rs Outdated Show resolved Hide resolved
crates/fe/src/task/compile.rs Outdated Show resolved Hide resolved
crates/fe/src/task/init.rs Outdated Show resolved Hide resolved
crates/fe/src/task/init.rs Outdated Show resolved Hide resolved
crates/fe/src/task/check.rs Outdated Show resolved Hide resolved
crates/fe/src/task/compile.rs Outdated Show resolved Hide resolved
@sbillig
Copy link
Collaborator

sbillig commented Jun 9, 2022

pro-tip: configuring your editor to fmt-on-save is a nice time-saver

@vuvoth vuvoth requested a review from sbillig June 10, 2022 10:38
@vuvoth
Copy link
Contributor Author

vuvoth commented Jun 10, 2022

Thanks for your good suggestions @sbillig!. I updated the PR.

  • fe build instead of fe compile. It would also be nice if this (and fe check) operated on the current project if no path is specified.

Could we do it after create fe.toml config? Should I create new issue for it?
Thanks ~~

@sbillig
Copy link
Collaborator

sbillig commented Jun 15, 2022

  • fe build instead of fe compile. It would also be nice if this (and fe check) operated on the current project if no path is specified.

Could we do it after create fe.toml config? Should I create new issue for it? Thanks ~~

Yep, that sounds fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants