Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 - PATH error #15118

Closed
banasiakadam60 opened this issue Sep 8, 2017 · 6 comments
Closed

Windows 10 - PATH error #15118

banasiakadam60 opened this issue Sep 8, 2017 · 6 comments

Comments

@banasiakadam60
Copy link

System information

Geth version: 1.6.5-cf87713d
OS & Version: Windows 10

Expected behaviour

During installation geth location should be added to the PATH

Actual behaviour

It fails with error: AddToPath: original length 117 > 1024 (or simmilar)
But can be added manually

Steps to reproduce the behaviour

Try to install geth on Windows 10 with many entries in PATH

Backtrace

https://user-images.githubusercontent.com/1128665/29494875-5af5264e-8568-11e7-84cb-65b3dfd0ba0c.jpg

@bas-vk
Copy link
Member

bas-vk commented Sep 11, 2017

That is a known limitation of NSIS. This check was added because in the past we had problems where the installer would corrupt the existing PATH. Will check if there is a solution.

@freakabcd
Copy link

Default NSIS_MAX_STRLEN is 1024. You'll need to build it yourself with a higher limit or use an existing special build with 8192 as the limit from here NSIS Special Builds

@fjl fjl mentioned this issue Oct 26, 2017
@MarinAngelo
Copy link

OK, but as I am definitely not able to fix this by my self, what is the effect? Does this mean that geth does not work correctely?

@fjl
Copy link
Contributor

fjl commented Oct 27, 2017

It just means that the geth installation directory is not listed in PATH. You might care about this if you expect to be able to open cmd.exe and type geth to launch it. If geth is not in PATH, you need to type the full path to the installation or add it to PATH yourself.

@MarinAngelo
Copy link

OK, thanks!

@stale
Copy link

stale bot commented Oct 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants