Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP address limits might not suitable for IPv6 #20522

Open
qin-nz opened this issue Jan 7, 2020 · 1 comment
Open

IP address limits might not suitable for IPv6 #20522

qin-nz opened this issue Jan 7, 2020 · 1 comment
Assignees

Comments

@qin-nz
Copy link

qin-nz commented Jan 7, 2020

Hi all,
In this code, geth restrict only 2 IP address is allowed in the same subnet (/24) to prevent from attack of the eclipse.

// IP address limits.
bucketIPLimit, bucketSubnet = 2, 24 // at most 2 addresses from the same /24

In IPv4, it's ok. But in IPv6, /24 is quite a big subnet.
For example,

I think good limit should be:

  • 2 ips for /48 subnet

Reasons:
/24 in IPv4 is the minium length in GLOBAL routing table.
/48 in IPv6 is the minium length in GLOBAL routing table.

For higher securtiy, the follwing limit may also be considerate:

  • 8 ips for /32 subnet
@qin-nz qin-nz changed the title IP address limits might not suit for IPv6 IP address limits might not suitable for IPv6 Jan 7, 2020
@fjl fjl self-assigned this Jan 8, 2020
@fjl
Copy link
Contributor

fjl commented Jan 8, 2020

Thank you for bringing this up. I will investigate how to improve IPv6 limits very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants