Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node flag to turn off transaction overdraft protection #27274

Closed
evanzbitgo opened this issue May 15, 2023 · 2 comments
Closed

Node flag to turn off transaction overdraft protection #27274

evanzbitgo opened this issue May 15, 2023 · 2 comments

Comments

@evanzbitgo
Copy link

evanzbitgo commented May 15, 2023

Rationale

The introduction of transaction overdraft protection has created challenges in certain automated transaction broadcasting scenarios, including my company. Our process involves generating a significant number of transactions and submitting them to our internal node's txpool. Our approach is to keep all pending transactions in the txpool, even if the fee address doesn't have enough balance, as we can add funds to the fee address later if needed. We encounter situations where we need to replace a pending transaction with a lower nonce. However, the overdraft protection feature initially rejects these replacement transactions, leading to manual intervention to resolve the issues.

Why should this feature exist?
For users with in-house nodes, they could have the flexibility to turn off this specific protection.

What are the use-cases?
See above

Implementation

Do you have ideas regarding the implementation of this feature?
Adding a node config flag
Are you willing to implement this feature?
Yes

@Georgezhang714
Copy link

Rationale

The introduction of transaction overdraft protection has created challenges in certain automated transaction broadcasting scenarios, including my company. Our process involves generating a significant number of transactions and submitting them to our internal node's txpool. Our approach is to keep all pending transactions in the txpool, even if the fee address doesn't have enough balance, as we can add funds to the fee address later if needed. We encounter situations where we need to replace a pending transaction with a lower nonce. However, the overdraft protection feature initially rejects these replacement transactions, leading to manual intervention to resolve the issues.

Why should this feature exist? For users with in-house nodes, they could have the flexibility to turn off this specific protection.

What are the use-cases? See above

Implementation

Do you have ideas regarding the implementation of this feature? Adding a node config flag Are you willing to implement this feature? Yes

Feature

@holiman
Copy link
Contributor

holiman commented Dec 4, 2023

It is hard for us to evaluate proposals in text-form. If you have a ready PR, it's easier to look at the code and judge if the maintenance overhead is worth it.

In this specific case, I would guess that we would not accept it. The usecase sounds very niche, and our main focus is maintaining an ethereum mainnet clients. At times, we accept modifications for non-ethereum-mainnet downstream usecases though, if they are elegant and/or minimal enough.

I'll close this ticket, feel free to open a PR with the proposed changes (but yeah, don't hope too much :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants