Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error logging as "error" not "eror #28768

Closed
alex067 opened this issue Jan 5, 2024 · 1 comment · Fixed by #28774
Closed

Fix error logging as "error" not "eror #28768

alex067 opened this issue Jan 5, 2024 · 1 comment · Fixed by #28774
Labels

Comments

@alex067
Copy link

alex067 commented Jan 5, 2024

System information

Geth version: geth version
CL client & version: e.g. lighthouse/nimbus/prysm@v1.0.0
OS & Version: Windows/Linux/OSX
Commit hash : (if develop)

Expected behaviour

When parsing through logs for errors, there is an inconsistency between the log level vs. standards. See: https://github.com/ethereum/go-ethereum/blob/master/log/logger.go

	case slog.LevelError:
		return "eror"

Actual behaviour

The expected behavior is log levels follow standard levels and errors be logged as "error" as opposed to "eror." For example, the LevelAlignedString properly assigns slog.LevelError as ERROR however LevelString is assigning it as eror

Steps to reproduce the behaviour

Backtrace

[backtrace]

When submitting logs: please submit them as text and not screenshots.

@rjl493456442
Copy link
Member

@jwasinger Is it a typo? Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants