Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a pool for polynomial allocations #64

Closed
gballet opened this issue Jun 22, 2021 · 4 comments
Closed

use a pool for polynomial allocations #64

gballet opened this issue Jun 22, 2021 · 4 comments
Assignees

Comments

@gballet
Copy link
Member

gballet commented Jun 22, 2021

In the new version of LeafNodes, an array of values needs to be allocated each time a new last-level node is created.

values:     make([][]byte, n.treeConfig.nodeWidth),

In the case of InsertOrdered, a performance gain could be realized by reusing a pool of nodes. This also works for children in InternalNode.

@muddlebee
Copy link

muddlebee commented Nov 9, 2021

@gballet hello 👋 I am participating in Ethereum's Core Developer Apprenticeship Program which runs through February 2022.

wanted to pick this issue and work on understanding the go-implementation of verkle trees. Do you have any specific timeline for this issue? So I can pick it up and work accordingly? If this is fine by you?

@muddlebee
Copy link

So according to my proposal for Developer Apprenticeship Program I wanted to pick a few issues from the go-verkle implementation and make an attempt to fix it by understanding the code. I believe go-verkle will soon be merged into the go-ethereum codebase. Any specific timelines?

So that I can make an attempt to contribute something meaningful to this project.

@gballet
Copy link
Member Author

gballet commented Nov 10, 2021

Sure, you can pick this issue if you want.

@gballet
Copy link
Member Author

gballet commented Apr 27, 2023

no longer needed, closing

@gballet gballet closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants