Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge template updates #36

Merged
merged 30 commits into from Sep 29, 2023
Merged

Merge template updates #36

merged 30 commits into from Sep 29, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Sep 28, 2023

What was wrong?

The template had a number of updates that hexbytes needed.

How was it fixed?

  • Merged template
  • Bumped mypy to 1.5.1

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

image

pacrob and others added 27 commits May 1, 2023 15:17
* new issue and pr templates
* convert bash scripts to py
* bump versions in dependencies and ci builds

* move tox to [dev] per issue ethereum#34

* move RTD deps pointer into .readthedocs.yml

* unpin flake8 add flake8-bugbear to lint deps
* remove gitter, testing setup, and pandoc sections, add quotes to dev install
* repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates
* template cleanup following initial merge with py-evm

* add flake8 pin comment

* correct license years

* add pin note to mypy
* apply template updates found following merge with eth-typing

* add build as a dev dependency

* remove timeout from pytest.ini, it doesn't do anything without pytest-timeout as a dep
* add updates found when merging template with py-ssz and eth-abi

* add wheel and wheel-windows to ci and reorg
* remove testall because it doesnt work
minor formatting updates, remove additional docs to separate pr
bump sphinx version and set py version rtd uses to 3.8
change references to doc to all be docs
Pre-release check for upstream configuration of remote
add `.venv*` to .gitignore
@pacrob pacrob force-pushed the upgrade-template branch 3 times, most recently from 6030fe9 to 4069478 Compare September 28, 2023 17:06
@pacrob pacrob force-pushed the upgrade-template branch 3 times, most recently from cc2561e to 52f413b Compare September 28, 2023 17:28
@pacrob pacrob changed the title Upgrade template Upgrade template and drop python 3.7 support Sep 28, 2023
@pacrob pacrob force-pushed the upgrade-template branch 2 times, most recently from d1031f3 to b7f3066 Compare September 28, 2023 17:38
drop py37 support

bump mypy
@pacrob pacrob changed the title Upgrade template and drop python 3.7 support Merge template updates and drop python 3.7 support Sep 28, 2023
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the .suppress-sphinx-build-warning file work as expected? I'm not finding documentation but I'm sure I'm just missing it.

lgtm!

@pacrob
Copy link
Contributor Author

pacrob commented Sep 29, 2023

Does the .suppress-sphinx-build-warning file work as expected? I'm not finding documentation but I'm sure I'm just missing it.

Noop, good catch, that's not supposed to be there. It gets auto-generated somewhere, but serves us no purpose. Edit - it's being deleted with my PR, it's just not clear (it usually says "file has been deleted" or something, right?). Maybe because it's an empty file. But to your question, nothing changes when I delete it, no new errors on docs building. And I can't find any documentation on it, which makes me think it's just leftover from some previous process.

@pacrob pacrob changed the title Merge template updates and drop python 3.7 support Merge template updates Sep 29, 2023
@pacrob pacrob force-pushed the upgrade-template branch 2 times, most recently from 3ee4563 to 2e87ccc Compare September 29, 2023 19:45
@pacrob pacrob merged commit b871062 into ethereum:master Sep 29, 2023
18 checks passed
@pacrob pacrob deleted the upgrade-template branch September 29, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants