Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requesitng *ack* when event is received #91

Open
pipermerriam opened this issue May 25, 2019 · 0 comments
Open

Allow requesitng *ack* when event is received #91

pipermerriam opened this issue May 25, 2019 · 0 comments

Comments

@pipermerriam
Copy link
Member

from #89

What was wrong?

It's easy to accidentally broadcast into the void with nobody subscribing to your broadcast and thus nobody listening.

How can it be fixed?

Extend BroadcastConfig to have a mechanism for requesting the receiver provide and ack.

Care should be taken to correctly handle or restrict this API for broadcasts that are sent to multiple recipients. The initial implementation should probably error if the broadcast is not limited to a single endpoint (such as requiring that filter_endpoint be set)

However, it should be reasonable to do something like count how many endpoints the event was broadcast to, and then to wait until we receive the same number of ack responses before returning to the user.

I am inclined to make this the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant