Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Timeout Github (updateChecker.js) #1124

Closed
esdrasedu opened this issue Aug 28, 2016 · 6 comments
Closed

Timeout Github (updateChecker.js) #1124

esdrasedu opened this issue Aug 28, 2016 · 6 comments

Comments

@esdrasedu
Copy link
Contributor

System information

Version: `0.8.2` (develop)
OS & Version: linux 4.7.2-1-ARCH x86_64
Node type: `geth 1.4.11`

Hello, I am having timeout for checking update, because the timeout setting is 3s (https://github.com/ethereum/mist/blob/develop/modules/updateChecker.js#L30), but in Brazil (where I am) github don't responds in 3s!

I think will be nice if change for 10s, because others countries the internet not is so good!

@esdrasedu
Copy link
Contributor Author

Will be nice if user receive return of timeout too!

@evertonfraga
Copy link
Member

Ok @esdrasedu! O Luca vai cuidar disso.

Por acaso era algum problema de proxy, ou timeout apenas?

@esdrasedu
Copy link
Contributor Author

esdrasedu commented Aug 31, 2016

Não estava usando proxy, apenas wifi mesmo (que piora um pouco a performance).
Acho q 3 segundos é pouco para request em países que possuem internet de baixa qualidade!
Seria legal poder ter uma notificacão do timeout, pois a impressão para usuário final é que "atualização" travou!

@luclu Do y understand portugues? Do y need translation for this?

@luclu luclu assigned luclu and unassigned luclu Sep 1, 2016
@luclu
Copy link
Contributor

luclu commented Sep 1, 2016

Thank you @esdrasedu. I get the gist! :)

@luclu
Copy link
Contributor

luclu commented Sep 14, 2016

PR: #1157

@luclu luclu closed this as completed Jan 10, 2017
@luclu luclu removed their assignment Mar 19, 2017
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants