Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4844 Implementers' Call #10 #701

Closed
timbeiko opened this issue Jan 2, 2023 · 5 comments
Closed

EIP-4844 Implementers' Call #10 #701

timbeiko opened this issue Jan 2, 2023 · 5 comments

Comments

@terencechain
Copy link
Contributor

terencechain commented Jan 2, 2023

Two things to discuss from my side:

1.) How should we handle blobs by range response on "zero" blob sidecar: ethereum/consensus-specs#3174

2.) The testing for devnet has some friction due to the latest breaking changes from the withdrawal spec. Different clients are rebasing based on different withdrawal spec versions. Now that the withdrawal spec is close to finalizing, we should pin down a capella version to rebase 4844.

Feature Devnet3 Devnet4
Withdrawal enabled 馃毇
Withdrawal without queue 馃毇
Withdrawal with bounded validator count 馃毇
Include blockValue in getPayload response 馃毇

@djrtwo
Copy link
Collaborator

djrtwo commented Jan 3, 2023

Re: 2 -- so even with the withdrawals functionality stubbed, the data structures are changed and thus must have agreement on this at a minimum.

Note: we have a spec release this friday with the final CL capella feature -- the historic accumulate revamp ethereum/consensus-specs#3165

Also note that re-enabling withdrawals functionality is to happen soon 鈩笍 -- ethereum/consensus-specs#3181

My preference on how things play out this month:

  • CL spec release -- v1.3.0-alpha.3 -- this week to include historic accumulators for Capella (essentially the mainnet release candidate)
  • Any 4844 testnets pre-interop target v1.3.0-alpha.3 (final capella data structures but capella functionality stubbed)
  • Capella testnets pre-interop and during interop target v1.3.0-alpha.3 (full capella functionality)
  • 4844 testnets at interop keep stubbed Capella functionality and unstub in a release immediately after interop (first week of feb)

I think the last point is most contentious. I'll put it on the CL call to discuss this coming week, but I believe keeping the functionality unencumbered would be the cleanest given the timelines at hand.

@djrtwo
Copy link
Collaborator

djrtwo commented Jan 3, 2023

(I won't be on call today)

re: ethereum/consensus-specs#3170

There was no opposition to the shift in spec on the CL call and all active spec maintainers I've discussed with agree that this is the appropriate place for the check.

I'd like to get this into the release at end of week.

@hwwhww
Copy link

hwwhww commented Jan 3, 2023

Re: the historic accumulate revamp ethereum/consensus-specs#3165

If 4844 interop needs to disable it, it has to revert process_epoch like this: ethereum/consensus-specs@72096ee

Considering process_historical_summaries_update is just an 8-line function in Python... I want to check if 4844 implementers want it to be disabled like this in the next spec release? It might be easier to just include this change.

@timbeiko
Copy link
Collaborator Author

timbeiko commented Jan 9, 2023

Closed in favour of #707

@timbeiko timbeiko closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants