Delete StateRootNotFound, execute_transaction() #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception is an overly-custom version of the MissingTrieNode exceptions. Just let those bubble up now. Now execute_transaction() is exactly the same as apply_transaction, so drop the method (and save the method overhead).
pipermerriam
approved these changes
Aug 5, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When handling missing node exceptions
StateRootNotFoundis an easy one to miss and only comes up very rarely. It's an unnecessary specialization of other exceptions now, IMO.How was it fixed?
The exception is an overly-custom version of the MissingTrieNode
exceptions. Just let those bubble up now.
Now
execute_transaction()is exactly the same asapply_transaction(), sodrop the method (and save the method overhead).
To-Do
Cute Animal Picture