Allow persisting headers that are disconnected from genesis #1823
Conversation
cburgdorf
force-pushed
the
christoph/spike/persist-orphan-header
branch
from
eb574e5
to
6738c00
Compare
eth/db/header.py
Outdated
| @@ -83,6 +83,10 @@ def persist_header(self, | |||
| ) -> Tuple[Tuple[BlockHeader, ...], Tuple[BlockHeader, ...]]: | |||
| raise NotImplementedError("ChainDB classes must implement this method") | |||
|
|
|||
| @abstractmethod | |||
| def persist_checkpoint_header(self, header: BlockHeader, score: int) -> None: | |||
| raise NotImplementedError("ChainDB classes must implement this method") | |||
There was a problem hiding this comment.
New paradigm uses ... for this.
pipermerriam
dismissed
their stale review
tests failing, waiting to see what tests say when conflicts are gone.
cburgdorf
force-pushed
the
christoph/spike/persist-orphan-header
branch
from
6738c00
to
835c9ad
Compare
Add an *optional* `genesis_parent_hash` parameter to `eth.db.header.HeaderDB.persist_header_chain` and `eth.db.chain.ChainDB.persist_block` that allows to overwrite the hash that is used to identify the genesis header. This allows persisting headers / blocks that aren't (yet) connected back to the true genesis header. This feature opens up new, faster syncing techniques.
cburgdorf
force-pushed
the
christoph/spike/persist-orphan-header
branch
from
835c9ad
to
6ac4322
Compare
Yes, I agree. But at the same time, it's strikingly simple so it may not be that bad after all :D
Yep, I started off on the previous release. But now that you upgraded Trinity to latest py-evm code (thanks for taking care of that!) I have this rebased and polished. |
|
I added another commit to kill the |
What was wrong?
We want to allow persisting headers that are disconnected from genesis (with the intend to connect them back later). This is to allow syncing from a trusted checkpoint.
How was it fixed?
Add an optional
genesis_parent_hashparameter toeth.db.header.HeaderDB.persist_header_chainandeth.db.chain.ChainDB.persist_blockthat allows to overwrite the hash that is usedto identify the genesis header. This allows persisting headers / blocks that aren't (yet)
connected back to the true genesis header.
To-Do
Cute Animal Picture