Arrow Glacier hard fork / EIP-4345 support #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
eip-4345
branch
3 times, most recently
from
f1f56ec
to
1ca990d
Compare
fselmo
force-pushed
the
eip-4345
branch
7 times, most recently
from
9805314
to
13e6869
Compare
wolovim
reviewed
Dec 14, 2021
fselmo
force-pushed
the
eip-4345
branch
5 times, most recently
from
ba8e31f
to
016ff1d
Compare
fselmo
force-pushed
the
eip-4345
branch
2 times, most recently
from
9cd7423
to
26302ee
Compare
Also updated test fixture to v10.2 to pull in the new `/DifficultyTests` and update the test suite. This had to be done by commit hash as updating the submodule was giving some issues. The commit hash can be found in the actual release notes for the new `ethereum/tests` here: https://github.com/ethereum/tests/releases/tag/v10.2
- Add a new `/json-fixtures` test for testing the newly added `ethereum/tests/DifficultyTests`. This includes tests for EIP-4345 for the new difficulty bomb changes.
wolovim
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
just around the corner[here] and we need to support it.How was it fixed?
ethereum/teststo version 10.2/json-fixtures/test_difficulty.pyto test against the newethereum/tests/DifficultyTestsTo-Do
ethereum/testsdifficulty testsCute Animal Picture