Address failing tests from ethereum/tests v11.1
#2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
changed the title
v11.1
fselmo
force-pushed
the
fix-broken-tests
branch
3 times, most recently
from
768bdde
to
ad84844
Compare
fselmo
force-pushed
the
fix-broken-tests
branch
2 times, most recently
from
99e516c
to
0ffb0d0
Compare
- Difficulty calculation was taking into account the parent ``difficulty`` which would slip below the ``DIFFICULTY_MINIMUM`` value if the parent ``difficulty`` was less than the allowed minimum. Instead, just take the max between the difficulty calculation and the actual minimum.
fselmo
force-pushed
the
fix-broken-tests
branch
from
0ffb0d0
to
24fc89c
Compare
fselmo
changed the title
v11.1v11.1
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to #2075
difficultywhich would slip below theDIFFICULTY_MINIMUMvalue if the parentdifficultywas less than the allowed minimum.How was it fixed?
Todo:
Cute Animal Picture