Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenSSL Config for ripemd160 #2087

Merged
merged 2 commits into from Nov 8, 2022
Merged

Update OpenSSL Config for ripemd160 #2087

merged 2 commits into from Nov 8, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Nov 4, 2022

What was wrong?

  • OpenSSL 3 removed ripemd160 functions from the default behavior. Instead they now have to be locally configured. This broke a lot of blockchain related logic and they decided to add it back in in version 3.0.7, see blog post here.

  • CircleCI is using openssl3 but not (yet?) the latest version. Since this breaks tests even on master, which were previously passing, we need to update the config for now until the newer open ssl version is used in the circleci images.

How was it fixed?

  • For now, updating the openssl config just works™ and we can ideally remove it when the images are updated.
  • Config changes suggested, among other places, here

Todo:

Cute Animal Picture

IMG_2333

@fselmo fselmo force-pushed the openssl branch 18 times, most recently from f7ec362 to 5e1ffe5 Compare November 7, 2022 18:01
@fselmo fselmo changed the title use openssl 3.0.7 Update OpenSSL Config for ripemd160 Nov 7, 2022
- ``openssl`` v3 removed ``ripemd160`` by default. They ended up putting it back in for default config since this broke a lot of blockchain-related projects (see blog post here: ).

- Until circleci updates openssl to ``3.0.7`` and above, we need to manually update the open ssl config locally on each build.
@fselmo fselmo marked this pull request as ready for review November 7, 2022 18:52
@fselmo fselmo requested review from kclowes and pacrob November 8, 2022 00:16
Copy link
Collaborator

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo
Copy link
Collaborator Author

fselmo commented Nov 8, 2022

Note: I emailed circleci support to ask where we can track the openssl version on the Python images. I will update here when I get a response but for now we can watch the version printed via the build step.

@fselmo fselmo merged commit f83866d into ethereum:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants