Shanghai hard fork support #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement base classes for Shanghai fork, inheriting from Paris - Implement EIP-3651: Warm COINBASE - Implement EIP-3855: PUSH0 instruction - Implement EIP-3860: Limit and meter initcode - Implement EIP-6049: Deprecate SELFDESTRUCT
fselmo
force-pushed
the
initial-shanghai-changes
branch
from
84a4892
to
ae5c407
Compare
fselmo
commented
Feb 27, 2023
fselmo
force-pushed
the
initial-shanghai-changes
branch
from
ae5c407
to
eb5ac84
Compare
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Feb 28, 2023
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Feb 28, 2023
fselmo
force-pushed
the
initial-shanghai-changes
branch
from
6c32447
to
6279e21
Compare
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Feb 28, 2023
fselmo
force-pushed
the
initial-shanghai-changes
branch
from
6279e21
to
adde6ad
Compare
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Mar 1, 2023
fselmo
force-pushed
the
initial-shanghai-changes
branch
from
adde6ad
to
1db1353
Compare
- Implement EIP-4895: Beacon chain push withdrawals as operations - Clean up some logic along the way and tighten up typing - Update ``ethereum/tests`` (fixtures subdirectory)
fselmo
force-pushed
the
initial-shanghai-changes
branch
4 times, most recently
from
d3dac44
to
f9d89cd
Compare
pacrob
reviewed
Mar 7, 2023
pacrob
reviewed
Mar 7, 2023
fselmo
force-pushed
the
initial-shanghai-changes
branch
3 times, most recently
from
9d445ed
to
87d4417
Compare
fselmo
force-pushed
the
initial-shanghai-changes
branch
2 times, most recently
from
1ee17e9
to
fd99f36
Compare
fselmo
force-pushed
the
initial-shanghai-changes
branch
from
fd99f36
to
448b81b
Compare
- Validate withdrawal fields as per EIP-4895 - Add some gut check tests for validation of withdrawal fields - Simplify empty account cleanup logic when withdrawal amount is 0
- Check for empty accounts to delete after applying all withdrawals, much in the same way we check at the end of transaction computations. - Add a test for testing withdrawal retrieval from the chaindb - Minor refactoring and fixes
- Add a deprecate method wrapper - Use this to wrap the opcode instructions for ``SELFDESTRUCT`` in the ``SHANGHAI_OPCODES`` - Add tests to make sure the deprecation warning is only listed for ``SELFDESTRUCT`` and only within the Shanghai VM
- Update ``eth-typing`` to ``3.3.0`` - Use ``ForkName.Shanghai`` value in tests
- Create a more general class method for validating the create message as a whole and bring the initcode size validation into that. This way, if other fields of the create message need validation in the future, we have a more useful method that's already abstracted and can be invoked in the proper VM computation class. - Consume the initcode cost before the computation starts for create transactions and handle initcode cost in the opcode implementations for ``CREATE`` and ``CREATE2``.
- All test vectors now applied to ``Shanghai`` rules.
- Tests that fit into the INCORRECT_UPSTREAM_TESTS in ``test_blockchain.py`` - Tests that time out
fselmo
force-pushed
the
initial-shanghai-changes
branch
from
448b81b
to
b88d6bd
Compare
kclowes
approved these changes
Apr 5, 2023
fselmo
added a commit
that referenced
this pull request
Apr 6, 2023
fselmo
added a commit
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Shanghai fork support needed:
How was it fixed?
Notes:
- The
fixturessubmodule (ethereum/tests) was updated to the latestv12.- There are many Shanghai
ethereum/testsrelated to EOF even though this was kicked down the line to theCancunhard fork. I've turned these off for now with a TODO to turn these back on once EOF is implemented. Currently, all other Shanghai-related tests are passing.Todo:
MergeandLondontests fromethereum/testsfixture updateCute Animal Picture