Merge in less-sensitive updates from the project template #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise tox fails, and the auto-lint never runs
Do not invoke `setup.py` directly; minor refactor + cleanup
bump docs dependencies, add readthedocs requirements
* new issue and pr templates
* convert bash scripts to py
* bump versions in dependencies and ci builds * move tox to [dev] per issue ethereum#34 * move RTD deps pointer into .readthedocs.yml * unpin flake8 add flake8-bugbear to lint deps
* remove gitter, testing setup, and pandoc sections, add quotes to dev install
* repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates
pacrob
changed the title
pacrob
force-pushed
the
join-to-template
branch
8 times, most recently
from
1e28f4e
to
df25855
Compare
pacrob
force-pushed
the
join-to-template
branch
from
df25855
to
ec2e9a9
Compare
kclowes
approved these changes
Apr 12, 2023
LICENSE
Outdated
| @@ -1,6 +1,6 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright 2017-2019 Ethereum Foundation | |||
| Copyright (c) 2020 The Ethereum Foundation | |||
There was a problem hiding this comment.
I have no idea how this works, but should we update this annually? As in, should this be 2023 now?
There was a problem hiding this comment.
As discussed, I'll update to the range of years in which changes were made to the library.
.pydocstyle.ini
Outdated
There was a problem hiding this comment.
I like that there are comments here that says what each code is!
I did take the entire template commit history, I just accepted local changes for the remaining files when fixing the merge conflicts. I don't think it will cause a problem. |
|
Got it. Sounds good to me! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The project template was updated. This is to merge in many of the changes from it.
Because there are so many changes, this PR is only for files that do not touch dependency or python versions (except for adding pydocstyle). Those will be done separately.
Files that need updating in following pr:
Cute Animal Picture