Re-refactor pre-EOF #2106
Merged
Re-refactor pre-EOF #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the state of the Computation class hierarchy mostly back to where it was, keeping some good cleanup and updating the ComputationAPI to match properties implemented in the base computation implementation class. Some of the earlier `ethereum/tests` pointed to EOF code within the bytecode, not at the start. This led to some wrong class architecting to make it work with our current model, with the bigger refactor commit from last week. It would be best to put the state of the Computation hierarchy mostly back to how it was so as to not break too much of the existing structure. Massaging EOF into this model won't be too difficult with the (proper) way the EOF tests are written now. Since there won't be a release until all these changes are in, the most this does is muddy the commit history a bit. But at least we gained a touch of housekeeping along the way.
fselmo
force-pushed
the
re-refactor-computation-and-executor
branch
from
a1ef2b7
to
6b026c4
Compare
pacrob
reviewed
May 4, 2023
pacrob
approved these changes
May 4, 2023
!
fselmo
force-pushed
the
re-refactor-computation-and-executor
branch
from
c0ad110
to
5ef8742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: EOF will no longer be in Cancun and the bytecode does not look like the current version of the
ethereum/teststhat are in our fixture directory. That update of the fixture will come in a separate PR. This change in the structure of the tests puts our code base mostly back to where it was to prepare for EOF implementation.This PR puts the state of the Computation class hierarchy mostly back to where it was, keeping some good cleanup and updating the
ComputationAPIto match properties implemented in theBaseComputationimplementation class.Some of the earlier
ethereum/testspointed to EOF code within the bytecode, not at the start. This led to a refactoring for the class architecture to make it work with our current model, with the bigger refactor PR from last week. With the updated tests (and checking against the EIPs), it would be best to put the state of the Computation hierarchy mostly back to where it was so as to not break too much of the existing structure. Massaging EOF into this model won't require as drastic of an architecture change.Since there won't be a release until all these changes are in, the most this does is muddy the commit history / git blame a bit 馃檨. At least we gained a touch of housekeeping along the way.
How was it fixed?
MessageComputationto make room for other*Computationclasses and return to the{ForkName}Computationbeing the overarching class that takes care of applying messages to state and "applying" itself during bytecode execution.Note: The newsfragment for the previous refactor PR (#2097) was removed and replaced with the one from this PR.
Todo:
Cute Animal Picture