New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CI-only docs builds for additional formats, update docs Makefile, add deletion of unused autogen docs #2137
Conversation
708fa4b
to
1b1bd11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now with the dev/doc dependencies installed, running make docs
locally is failing. I think we'll need to add a few dependencies to either docs
or dev
deps.
I had to install the latex dependencies locally for it to build properly. My requirements were the same Edit: discussed, the install requirements for building latex locally are pretty hefty. Defining a CI-only docs build in Makefile. |
…te unused auto-gen docs that appear with `make build-docs`
f6abddd
to
e381738
Compare
@@ -1,20 +1,180 @@ | |||
# Minimal makefile for Sphinx documentation | |||
# Makefile for Sphinx documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this come from somewhere as a template? Can you add a reference if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! From the python project template:
https://github.com/ethereum/ethereum-python-project-template/blob/main/docs/Makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good here. Approving, but did notice a prexisting issue with the docs build.
I was looking at the failing docs badge and turns out there's an error importing a sphinx extension. There was minimal information I could find related to the version we're using, pinned to 0.2.0 due to 0.3.0 causing another error.
Any idea what could fix this issue?
Running Sphinx v6.2.1
Extension error:
Could not import extension sphinxcontrib.asyncio (exception: cannot import name 'PyModulelevel' from 'sphinx.domains.python' (/Users/reedsa/.pyenv/versions/3.10.12/envs/py-evm/lib/python3.10/site-packages/sphinx/domains/python.py))
make[1]: *** [html] Error 2
make: *** [build-docs] Error 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
What was wrong?
Build on RTD has been failing, but only when a PR is merged into
main
. In our own docs testing, we only test building the html version of the docs, but for several months now we've had RTD building html, pdf, and epub versions for almost all our libs. It seems like there hasn't been an issue, but in this case the html docs build fine but the epub build fails.How was it fixed?
Created a new
validate-docs-ci
make command, which will build pdf and epub only as part of CI. Tried changing it so all docs building builds all 3 formats, but the local reqs for buildinglatexpdf
are hefty.Fix issues with epub build by restructuring the introduction and guides so that the
quickstart.rst
(nowinstallation.rst
is only included once.Updated
docs/Makefile
to template version(not sure why that didn't happen in the recent general update) and added to the docs Makefileclean
directive to specifically delete the autogenerated docs we don't use.Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture