Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement transient storage #2142

Merged

Conversation

charles-cooper
Copy link
Contributor

@charles-cooper charles-cooper commented Feb 18, 2024

What was wrong?

re: EIP-1153
depends on #2141
possible dup of #2138 (@pacrob you are welcome to pull these changes into your branch, or work on this branch, any workflow is ok with me)

i didn't add tests, and there are still some lint issues. could use some help / bandwidth here! but the basic structure and implementation should be in place.

Todo:

Cute Animal Picture

Screenshot 2024-03-13 at 12 25 30

@pacrob pacrob changed the base branch from main to cancun-network-upgrade February 21, 2024 22:34
@fselmo fselmo force-pushed the feat/transient-storage branch 2 times, most recently from d17138a to e2e4c83 Compare March 13, 2024 18:08
fselmo added a commit to charles-cooper/py-evm that referenced this pull request Mar 13, 2024
fselmo and others added 2 commits March 13, 2024 12:24
- fix transient storage gas costs
- fix mypy
- fix bugs
- JournalDB values should be bytes
- fix some type signatures
- turn on 1153 tests for ci
- add some missing type hints and abstract methods
- tload is allowed in staticcall
- add ensure_no_static to tload/tstore
- move the logic functions to cancun/logic.py

Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of 4844 and 7516 changes and squashed commits. Lgtm, we can tackle some organization changes in a subsequent release if needed. Thanks for the contribution 👍🏼

@fselmo
Copy link
Collaborator

fselmo commented Mar 13, 2024

Note: cancun-network-upgrade feature branch will have 3 failing tests for 1153 until selfdestruct updates are merged in

@fselmo fselmo merged commit 88e521e into ethereum:cancun-network-upgrade Mar 13, 2024
42 of 48 checks passed
fselmo added a commit that referenced this pull request Mar 14, 2024
@fselmo fselmo mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants