EIP-4844 and EIP-7516 support #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid repeated code for `calculate_intrinsic_gas` and in a few other places by using a basic inheritance pattern for unsigned typed transactions. - This commit also fixes type hinting in a few places.
- Keep track of known header fields and raise a ``ValidationError`` if more fields are in the header than are known. This will help with a lot of headaches in the future. - Add a note to make sure the normalization of fields is updated as well.
- Get tests working for point evaluation.
fselmo
force-pushed
the
eip-4844-support
branch
from
850d454
to
d43ee77
Compare
- Invalid blob gas delta tests would hang indefinitely if the gas delta was no longer significant because of the exponential nature of the ``fake_exponential`` calculation. Instead, prevent the calculation from approximating beyond 10,000 iterations of the method as a baseline. We may need to adjust this number in the future if this somehow becomes problematic but it passes all ethereum tests and seems like a reasonable number for now. - Turn those slow tests back on.
fselmo
force-pushed
the
eip-4844-support
branch
2 times, most recently
from
ae4fb5a
to
1751323
Compare
- The state of transaction typing is quite messy. This will have to be addressed separately since this is a significant enough PR already. For now, de-DRY some of the changes made earlier and type: ignore some of the Cancun transaction fields until we fix the typing situation.
fselmo
force-pushed
the
eip-4844-support
branch
from
1751323
to
2941163
Compare
fselmo
commented
Mar 13, 2024
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Mar 13, 2024
fselmo
force-pushed
the
eip-4844-support
branch
from
4059be0
to
22d1a22
Compare
fselmo
merged commit 74e82b0
into
ethereum:cancun-network-upgrade
42 of 47 checks passed
fselmo
added a commit
that referenced
this pull request
Mar 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-4844 support
ckzglibrary.blob_gas_usedandexcess_blob_gason Cancun block headersNote: The state of the API and transaction field classes is quite messy. We should address this in a separate PR. This will have a few undesired
type: ignorelines for now until we can fix the API ABC class mess that's happening across legacy vs type, signed vs unsigned, fields vs methods... etc... I'll attempt to fix this before we merge cancun to main but maybe we can release with working logic and clean up the typing after the first cancun support release. Any thoughts on that release process are welcome.Todo:
Cute Animal Picture