Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on Cancun transition tests and address issues #2156

Merged
merged 2 commits into from Mar 15, 2024

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Mar 15, 2024

New transition tests no longer live under /BlockchainTests/TransitionTests/... and so we didn't catch any Shanghai to Cancun tests. This PR turns those on and more properly addresses transition test setup dealing with a timestamp by introducing helper functions to set them up properly.

  • Address issues at Shanghai -> Cancun transition.
  • Add helpers for testing transition tests at timestamp.
  • Fix the keywords for CI transition tests since they no longer live in /TransitionTests.

Todo:

Cute Animal Picture

prompt: snakes transitioning from the Shanghai city life to a life in Cancun with a sign that says "Cancun"

Screenshot 2024-03-15 at 13 23 18

fselmo added a commit to fselmo/py-evm that referenced this pull request Mar 15, 2024
@fselmo fselmo marked this pull request as ready for review March 15, 2024 19:23
fselmo added a commit to fselmo/py-evm that referenced this pull request Mar 15, 2024
@fselmo fselmo force-pushed the bugfix-at-cancun-transition branch from dc574e7 to aec66e9 Compare March 15, 2024 19:40
@fselmo fselmo requested review from kclowes and pacrob March 15, 2024 19:41
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass! :shipit:

- Address issues at Shanghai -> Cancun transition.
- Add helpers for testing transition tests at timestamp.
- Fix the keywords for CI transition tests since they no longer live
  in ``/TransitionTests``.
@fselmo fselmo force-pushed the bugfix-at-cancun-transition branch from aec66e9 to 4c99b04 Compare March 15, 2024 19:55
@fselmo fselmo merged commit d4fd330 into ethereum:main Mar 15, 2024
1 of 46 checks passed
@fselmo fselmo deleted the bugfix-at-cancun-transition branch March 15, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants