fix: cancun transaction executor #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in chain.estimate_gas(), the chain creates a snapshot, applies a transaction, then reverts the snapshot. the issue with this is applying a transaction creates a new JournalDB inside of the transient storage, so the checkpoint from the snapshot is no longer valid as soon as apply_transaction() is called. this commit cleans the transient storage db by calling JournalDB.clear() so that the checkpoint from the snapshot is still valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in chain.estimate_gas(), the chain creates a snapshot, applies a transaction, then reverts the snapshot. the issue with this is applying a transaction creates a new JournalDB inside of the transient storage, so the checkpoint from the snapshot is no longer valid as soon as apply_transaction() is called. this commit cleans the transient storage db by calling JournalDB.clear() so that the checkpoint from the snapshot is still valid.
What was wrong?
Related to Issue #
Closes #
How was it fixed?
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture