Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade template #134

Merged
merged 48 commits into from Dec 7, 2023
Merged

Upgrade template #134

merged 48 commits into from Dec 7, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Dec 1, 2023

What was wrong?

Updates from the project template, notably:

  • use pre-commit for linting
  • drop py37 support
  • change the name of the master branch to main
  • bumped the version of flake8 - lots of reformats

Closes #130
Closes #131

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

image

pacrob and others added 30 commits May 1, 2023 15:17
* convert bash scripts to py
* bump versions in dependencies and ci builds

* move tox to [dev] per issue ethereum#34

* move RTD deps pointer into .readthedocs.yml

* unpin flake8 add flake8-bugbear to lint deps
* remove gitter, testing setup, and pandoc sections, add quotes to dev install
* repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates
* template cleanup following initial merge with py-evm

* add flake8 pin comment

* correct license years

* add pin note to mypy
…m#81)

* apply template updates found following merge with eth-typing

* add build as a dev dependency

* remove timeout from pytest.ini, it doesn't do anything without pytest-timeout as a dep
* add updates found when merging template with py-ssz and eth-abi

* add wheel and wheel-windows to ci and reorg
* remove testall because it doesnt work
minor formatting updates, remove additional docs to separate pr
…sion

bump sphinx version and set py version rtd uses to 3.8
change references to doc to all be docs
Pre-release check for upstream configuration of remote
add `.venv*` to .gitignore
add `.build` to be ignored
fix indent, add sphinx fail_on_warning
gitignore local vs-code settings
* add pre-commit

* run pre-commit

* skip lint on README.md as it breaks template filling
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@pacrob pacrob merged commit 00858d5 into ethereum:main Dec 7, 2023
18 checks passed
@pacrob pacrob deleted the upgrade-template branch December 7, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade isort upgrade flake8
5 participants