Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization #36

Open
hwwhww opened this issue Feb 5, 2019 · 1 comment
Open

Optimization #36

hwwhww opened this issue Feb 5, 2019 · 1 comment
Assignees

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Feb 5, 2019

What was wrong?

How can it be fixed?

Any other optimization ideas?

@hwwhww hwwhww self-assigned this Feb 6, 2019
This was referenced Feb 6, 2019
@jannikluhn
Copy link
Contributor

Any other optimization ideas?

It would be a rather big change and I have no idea how much we would gain (if anything), but it would be interesting to look into memoryviews. We do quite a bit of slicing when deserializing nested objects and with bytes this means a lot of unnecessary copying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants