New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce object churn for instruction types #37
Comments
Worth noting that @davesque and I talked this over today and my conclusion is that this should just be removed entirely for the time being.
|
If this library should be usable to run typical web assembly modules, then I can imagine that the average module in the broader world of WASM (not just the Ethereum world) could be quite large. So it may actually be necessary to reduce the memory footprint of all those instruction instances. However, in the Ethereum world, this probably does still count as premature optimization. I've also been an advocate of using |
After some profiling we should remove the |
What is wrong
The
Instruction
classes use a metaclass pattern to intern instance values for re-use in order to reduce the overall number of objects that need to be instantiated.How can it be fixed
The text was updated successfully, but these errors were encountered: