convert .format to f-strings #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
f-strings-please
branch
2 times, most recently
from
6d1e3c0
to
b509e15
Compare
fselmo
reviewed
Oct 11, 2023
rlp/sedes/big_endian_int.py
Outdated
| @@ -25,7 +25,7 @@ def serialize(self, obj): | |||
| raise SerializationError("Can only serialize integers", obj) | |||
| if self.length is not None and obj >= 256**self.length: | |||
| raise SerializationError( | |||
| "Integer too large (does not fit in {} " "bytes)".format(self.length), | |||
| "Integer too large (does not fit in {self.length} bytes)", | |||
There was a problem hiding this comment.
Missing f here. This will print "self.length" not the value of self.length
There was a problem hiding this comment.
Good catch, thank you!
pacrob
force-pushed
the
f-strings-please
branch
from
b509e15
to
3269386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
.formatstrings.How was it fixed?
Todo:
Cute Animal Picture