Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: support individual EIP activation #69

Closed
gumb0 opened this issue Nov 14, 2019 · 4 comments
Closed

Feature suggestion: support individual EIP activation #69

gumb0 opened this issue Nov 14, 2019 · 4 comments

Comments

@gumb0
Copy link
Member

gumb0 commented Nov 14, 2019

This could help with adopting EIP-centric forking process and allowing EIP champions to generate tests from their reference implementation without it being merged into clients' main line.

The idea is to support the tests format where in place of a fork name you would have a string like ForkName+XXX where ForkName is one of Frontier, Homestead etc. and XXX is the number of one of the proposed (but not yet accepted) EIPs. See ethereum/tests@8bbbd48#diff-ee4ed374f5a8e138384eb7782c7b808fR39 for an example of such test.

Currently geth and aleth already support this kind of "fork name" in their testing tools.

For this to work in retesteth you would need clients to also support chain config format that includes these additional EIPs (so that retesteth could send it via setChainParams.)
Aleth doesn't yet support this, but it's not difficult to implement when needed, the main challenge is to come up with the exact chain config format for this.

@winsvega
Copy link
Collaborator

retesteth has nothing to do with this. everything is now configurable.
you could set up any forkName in the options and assign any chainParams json for this name for any client. and generate the tests with it.

@winsvega
Copy link
Collaborator

contradicts: #67

@gumb0
Copy link
Member Author

gumb0 commented Nov 27, 2019

Ok I see, makes sense.

Another thing I would find inconvenient for creating the tests for new EIPs is the need to put them into one of the existing suites / test folders. Or otherwise the need to modify the source of retesteth to create a new suite.
(maybe an option to generate tests out of any custom file / folder outside of test folder structure would help with this)

@winsvega
Copy link
Collaborator

winsvega commented Nov 29, 2019

64a9120

run a custom test file like in testeth using --testfile option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants