SMC: missing notary deposit

[hwwhww]

What is wrong?

It seems the balance storage is forgotten...? But might only worthwhile to fix if there will be slashing condition for the notaries. Right now I just add it to backlogs, not a high priority.

How can it be fixed

notary_registry: should be notary_registry: {deregistered: int128, pool_index: int128, deposit: wei_value}[address].

sharding/contracts/validator_manager.v.py

Lines 37 to 40 in 38f437c

	notary_registry: {
	deregistered: int128,
	pool_index: int128
	}[address]

When release_notary: should return the balances instead of NOTARY_DEPOSIT:

sharding/contracts/validator_manager.v.py

Line 230 in 38f437c

send(msg.sender, self.NOTARY_DEPOSIT)

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 0.08 ETH (58.27 USD @ $728.39/ETH) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $8,041.12 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 8 months, 4 weeks ago.
Please review their action plans below:

1) dilatebrave has started work.

I will keep informed every few days

Learn more on the Gitcoin Issue Details page.

[hwwhww]

Hi @dilatebrave!
This ticket has two parts:

1. Update Vyper code:
   • Adding deposit: wei_value field in notary_registry to store the deposit size. (msg.value)
   • Updating logic that related to deposit, refund deposit when release_notary.
2. Upload json file bytecode
   • Here is the guide Steps of Compiling Sharding Manager Contract(SMC) by @NIC619

Note that Vyper version we are using is:

sharding/requirements-dev.txt

Line 11 in cb8f5b5

git+git://github.com/ethereum/vyper.git@044d1565df370cd31c00fc7fb728672647f39cf2

Thanks! Feel free to ask question here.

[dilatebrave]

@hwwhww --- thanks a lot
but i can not view https://hackmd.io/s/BysXg663M

[hwwhww]

@dilatebrave Sorry! We just updated the permission, can you view it now?

[dilatebrave]

@hwwhww --- thanks a lot ^^
my previous commit use https://vyper.readthedocs.io/en/latest/compiling-a-contract.html to compile, it looks like the result are the same so i think it done

[hwwhww]

Thanks, @dilatebrave!

@vs77bb LGTM to pay @dilatebrave. 👍

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 0.08 ETH (58.66 USD @ $733.26/ETH) has been submitted by:

1. @dilatebrave

@vs77bb please take a look at the submitted work:

• PR by @dilatebrave

---

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
  $7,995.41 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

The funding of 0.08 ETH (58.55 USD @ $731.87/ETH) attached to this issue has been approved & issued to @dilatebrave.

• Learn more at on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $6,936.93 more funded OSS Work available on the Gitcoin Issue Explorer

[vs77bb]

@hwwhww Bounty funds have been released! Great work, @dilatebrave 😄