Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA-256 hashes to file lists in solc-bin #10379

Closed
cameel opened this issue Nov 23, 2020 · 2 comments · Fixed by #10932 or ethereum/solc-bin#82
Closed

Add SHA-256 hashes to file lists in solc-bin #10379

cameel opened this issue Nov 23, 2020 · 2 comments · Fixed by #10932 or ethereum/solc-bin#82

Comments

@cameel
Copy link
Member

cameel commented Nov 23, 2020

Proposed by @axic in #10352 (comment).

Hmm, didn't we also had a sh256 hash next to this? That is way more useful for anyone downloading a static compiler from here and trying to verify it on CI (as that works with shasum -a 256 ).

After doing this the example in solc-bin docs should be updated to include such a hash too.

@cameel cameel added this to New issues in Solidity via automation Nov 23, 2020
@cameel cameel moved this from New issues to Implementation Backlog in Solidity Nov 23, 2020
@rainbreak
Copy link
Contributor

rainbreak commented Nov 25, 2020

Yes please, it's way easier to deal with sha256. In particular, NixOS requires a sha256 when fetching a url and can't accept keccak256, so I have to manually calculate the sha256.

@cameel cameel self-assigned this Nov 26, 2020
Solidity automation moved this from Implementation Backlog to Done Feb 15, 2021
@axic
Copy link
Member

axic commented Nov 10, 2021

Finally found that I actually did this years ago, that's why I was confused in the opening comment why it wasn't done: ethereum/solc-bin#19 (commit dcbf73d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Solidity
  
Done
3 participants