This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Ensure JSON RPC requests end with newline #1388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
This is basically #1121 which I can not reopen for some reason.
dopple does currently not work with Trinity because it assumes that every response ends with a newline character.
How was it fixed?
We could change dopple to not rely on newlines and match closing brackets instead (this is what web3.py does) but I don't think it's worth is because:
Other clients (at least geth and aleth) end responses with new lines so maybe they are right about that?
It is very easy to fix this on our part and just add that newline
Bracket matching will be slower and it might not feel like a good move to others to make dopple slower just to be compatible to Trinity.
After talking to @carver about this recently, I'm convinced we should just add that newline on our end.
To-Do
Cute Animal Picture