Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Refactor signature hashing to use new unified ssz method #304

Closed
hwwhww opened this issue Feb 25, 2019 · 3 comments
Closed

Refactor signature hashing to use new unified ssz method #304

hwwhww opened this issue Feb 25, 2019 · 3 comments
Labels
eth2.0

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Feb 25, 2019

What is wrong?

Spec PR: ethereum/consensus-specs#633

How can it be fixed

Blocking: Pending on SSZ ethereum/py-ssz#44.

  1. Update ProposerSlashing fields
  2. Update ProposalSignedData fields and rename it to Proposal
  3. Apply SSZ signed_root for signing.

IMO (1, 2) and 3 can be two tasks.
@hwwhww hwwhww added the eth2.0 label Feb 25, 2019
@ralexstokes
Copy link
Member

(1) and (2) were probably outdated by work in #470.

It looks like we can update which py-ssz we are using and then use the inherited signing_root :)

@ralexstokes
Copy link
Member

Looks like #499 will close this. I'll loop back around once it is merged

@ralexstokes
Copy link
Member

Looks like we did this, closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eth2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralexstokes @hwwhww