Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Review and rework per-epoch processing: crosslink #383

Closed
2 tasks
hwwhww opened this issue Mar 8, 2019 · 1 comment
Closed
2 tasks

Review and rework per-epoch processing: crosslink #383

hwwhww opened this issue Mar 8, 2019 · 1 comment
Assignees
@NIC619
Labels
eth2.0
Milestone
eth2 - spec v0.5.1

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Mar 8, 2019 •
edited
Loading

What is wrong?

Spec Meteorite 711 Pythonized the per-epoch processing, also made the logic much more clear than before. We would need to ensure we are following the correct logic.

How can it be fixed

Know issues:

  • tie break for winning_root favors lexicographically higher hashes rather than lower
  • handle case when no attestations available for a particular shard when crosslinking (ethereum/consensus-specs@47cca60) (bugfix)

And also, check our codebase is aligning with the spec.
@hwwhww hwwhww added the eth2.0 label Mar 8, 2019
@hwwhww hwwhww mentioned this issue Mar 8, 2019
Closed
@NIC619 NIC619 mentioned this issue Mar 9, 2019
Merged
5 tasks
@hwwhww hwwhww added this to the eth2 - spec v0.5.0 milestone Mar 16, 2019
@NIC619
Copy link
Contributor

NIC619 commented Mar 26, 2019

Closed in #390

@NIC619 NIC619 closed this as completed Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NIC619 NIC619

Labels
eth2.0
Projects
None yet
Milestone
eth2 - spec v0.5.1
Development

No branches or pull requests
2 participants
@hwwhww @NIC619