WIP: RLP decode tx inject #1265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any way to get rid of this pre-deployed library entirely? I think Solidity 0.5 they did |
|
@fubuloubu not sure what you mean? inling instead? |
|
Yeah, I believe the ABI decoder rewrite eliminated most of the use of RLP and turned into an online feature to save gas on external calls and such. Something to put on the roadmap for release, it would be huge UX improvement |
|
@fubuloubu Ah OK, let's get this function working first. Then we can worry about stuff like that. |
|
@jacqueswww I was wrong about this in my initial comment, I am in favor of this if you could rebase. |
fubuloubu
added
the
work in progress
|
Please rebase/refactor this work and reopen the PR when you're ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes #522
How I did it
How to verify it
Description for the changelog
Cute Animal Picture