Add test for close event and TODOs to remove close

web3 · Nov 13, 2020 · 09cc191 · 09cc191
1 parent 011aafa
commit 09cc191
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/web3-core-requestmanager/src/index.js b/packages/web3-core-requestmanager/src/index.js
@@ -137,6 +137,7 @@ RequestManager.prototype.setProvider = function (provider, net) {
                 _this.provider.emit('end', event);
             }
         };
+        // TODO: Remove close once the standard allows it
         this.provider.on('close', disconnect);
         this.provider.on('disconnect', disconnect);
 

diff --git a/test/3_givenProvider-ganache.js b/test/3_givenProvider-ganache.js
@@ -30,7 +30,10 @@ describe('web.providers.givenProvider (ganache)', function(){
         assert.equal(1, web3.currentProvider.listenerCount('data'))
         assert.equal(1, web3.currentProvider.listenerCount('connect'))
         assert.equal(1, web3.currentProvider.listenerCount('error'))
-        assert.equal(1, web3.currentProvider.listenerCount('disconnect'))
+        // TODO: Remove close once the standard allows it
+        assert(
+            web3.currentProvider.listenerCount("disconnect") === 1 || web3.currentProvider.listenerCount("close") === 1
+        );
     });
 
     it('deploys a contract', async function(){