Merge branch '1.x' into 1.x

web3 · Sep 26, 2020 · 5e19a84 · 5e19a84
2 parents e7adda5 + 9b92aac
commit 5e19a84
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -289,3 +289,7 @@ Released with 1.0.0-beta.37 code base.
 ## [Unreleased]
 
 ## [1.3.1]
+
+### Removed
+
+- Removed post-install script in `packages/web3`. Added documentation to root README (#3717)
diff --git a/README.md b/README.md
@@ -101,6 +101,15 @@ If you are using the types in a `commonjs` module, like in a Node app, you just
     ....
 ```
 
+## Trouble shooting and known issues.
+
+### Web3 and Angular
+If you are using Ionic/Angular at a version >5 you may run into a build error in which modules `crypto` and `stream` are `undefined`
+
+a work around for this is to go into your node-modules and at `/angular-cli-files/models/webpack-configs/browser.js` change  the `node: false` to `node: {crypto: true, stream: true}` as mentioned [here](https://github.com/ethereum/web3.js/issues/2260#issuecomment-458519127)
+
+Another variation of this problem was an issue opned on angular-cli: https://github.com/angular/angular-cli/issues/1548
+
 ## Documentation
 
 Documentation can be found at [ReadTheDocs][docs].

diff --git a/packages/web3/angular-patch.js b/packages/web3/angular-patch.js
diff --git a/packages/web3/package.json b/packages/web3/package.json
@@ -20,8 +20,7 @@
     "types": "types/index.d.ts",
     "scripts": {
         "tsc": "tsc -b tsconfig.json",
-        "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types",
-        "postinstall": "node angular-patch.js"
+        "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types"
     },
     "authors": [
         {