Skip to content

Commit

Permalink
changed extend to _extend
Browse files Browse the repository at this point in the history
  • Loading branch information
frozeman committed Jun 8, 2015
1 parent d14c706 commit 7518ed4
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 31 deletions.
10 changes: 5 additions & 5 deletions dist/web3-light.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/web3-light.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/web3-light.min.js

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions dist/web3.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/web3.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/web3.min.js

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions lib/web3.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ Object.defineProperty(web3.eth, 'defaultAccount', {


// EXTEND
web3.extend = function(extension){
web3._extend = function(extension){
/*jshint maxcomplexity: 6 */

if(extension.property && !web3[extension.property])
Expand All @@ -160,10 +160,10 @@ web3.extend = function(extension){
setupMethods(web3[extension.property] || web3, extension.methods || []);
setupProperties(web3[extension.property] || web3, extension.properties || []);
};
web3.extend.formatters = formatters;
web3.extend.utils = utils;
web3.extend.Method = require('./web3/method');
web3.extend.Property = require('./web3/property');
web3._extend.formatters = formatters;
web3._extend.utils = utils;
web3._extend.Method = require('./web3/method');
web3._extend.Property = require('./web3/property');


/// setups all api methods
Expand Down
24 changes: 12 additions & 12 deletions test/web3.extend.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,40 +5,40 @@ var web3 = require('../lib/web3');


var tests = [{
properties: [new web3.extend.Property({
properties: [new web3._extend.Property({
name: 'gasPrice',
getter: 'eth_gasPrice',
outputFormatter: web3.extend.formatters.outputBigNumberFormatter
outputFormatter: web3._extend.formatters.outputBigNumberFormatter
})]
},{
methods: [new web3.extend.Method({
methods: [new web3._extend.Method({
name: 'getBalance',
call: 'eth_getBalance',
params: 2,
inputFormatter: [web3.extend.utils.toAddress, web3.extend.formatters.inputDefaultBlockNumberFormatter],
outputFormatter: web3.extend.formatters.outputBigNumberFormatter
inputFormatter: [web3._extend.utils.toAddress, web3._extend.formatters.inputDefaultBlockNumberFormatter],
outputFormatter: web3._extend.formatters.outputBigNumberFormatter
})]
},{
property: 'admin',
properties: [new web3.extend.Property({
properties: [new web3._extend.Property({
name: 'gasPrice',
getter: 'eth_gasPrice',
outputFormatter: web3.extend.formatters.outputBigNumberFormatter
outputFormatter: web3._extend.formatters.outputBigNumberFormatter
})],
methods: [new web3.extend.Method({
methods: [new web3._extend.Method({
name: 'getBalance',
call: 'eth_getBalance',
params: 2,
inputFormatter: [web3.extend.utils.toAddress, web3.extend.formatters.inputDefaultBlockNumberFormatter],
outputFormatter: web3.extend.formatters.outputBigNumberFormatter
inputFormatter: [web3._extend.utils.toAddress, web3._extend.formatters.inputDefaultBlockNumberFormatter],
outputFormatter: web3._extend.formatters.outputBigNumberFormatter
})]
}];

describe('web3', function () {
describe('extend', function () {
describe('_extend', function () {
tests.forEach(function (test, index) {
it('test no: ' + index, function () {
web3.extend(test);
web3._extend(test);


if(test.properties)
Expand Down

0 comments on commit 7518ed4

Please sign in to comment.