Wrap more immediate errors in 0 length timeouts

web3 · Jan 6, 2020 · 9038a7a · 9038a7a
1 parent d21d746
commit 9038a7a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/packages/web3-core-subscriptions/src/subscription.js b/packages/web3-core-subscriptions/src/subscription.js
@@ -246,8 +246,10 @@ Subscription.prototype.subscribe = function() {
                 // TODO subscribe here? after the past logs?
 
             } else {
-                _this.callback(err, null, _this);
-                _this.emit('error', err);
+                setTimeout(function(){
+                    _this.callback(err, null, _this);
+                    _this.emit('error', err);
+                },0);
             }
         });
     }
@@ -289,8 +291,10 @@ Subscription.prototype.subscribe = function() {
                 }
             });
         } else {
-            _this.callback(err, false, _this);
-            _this.emit('error', err);
+            setTimeout(function(){
+                _this.callback(err, false, _this);
+                _this.emit('error', err);
+            },0);
         }
     });
 

diff --git a/test/eth.subscribe.ganache.js b/test/eth.subscribe.ganache.js
@@ -43,6 +43,16 @@ describe('subscription connect/reconnect', function() {
             });
     });
 
+    it('subscription emits a connected event', function(done){
+        subscription = web3.eth
+            .subscribe('newBlockHeaders')
+            .on('connected', function(result){
+                assert(result)              // First subscription
+                subscription.unsubscribe(); // Stop listening..
+                done();
+            });
+    });
+
     it('resubscribes to an existing subscription', function(done){
         this.timeout(5000);