Merge pull request #2871 from ethereum/enhancement/non-static-type-pr…

…operty-added non-static type property added
web3 · Jun 4, 2019 · c3f4845 · c3f4845
2 parents f0d941f + 70c211d
commit c3f4845
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/web3-core-method/lib/methods/transaction/AbstractObservedTransactionMethod.js b/packages/web3-core-method/lib/methods/transaction/AbstractObservedTransactionMethod.js
@@ -42,14 +42,23 @@ export default class AbstractObservedTransactionMethod extends AbstractMethod {
     }
 
     /**
-     * This type will be used in the AbstractMethodFactory.
+     * This type will be used in the AbstractMethodFactory.and BatchRequest class
      *
      * @returns {String}
      */
     static get Type() {
         return 'observed-transaction-method';
     }
 
+    /**
+     * This type will be used in the AbstractMethodFactory and BatchRequest class
+     *
+     * @returns {String}
+     */
+    get Type() {
+        return 'observed-transaction-method';
+    }
+
     /**
      * Sends the request and returns a PromiEvent Object
      *

diff --git a/...s/web3-core-method/tests/lib/methods/transaction/AbstractObservedTransactionMethodTest.js b/...s/web3-core-method/tests/lib/methods/transaction/AbstractObservedTransactionMethodTest.js
@@ -65,6 +65,8 @@ describe('AbstractObservedTransactionMethodTest', () => {
         expect(method.transactionObserver).toEqual(transactionObserverMock);
 
         expect(method.promiEvent).toBeInstanceOf(PromiEvent);
+
+        expect(method.Type).toEqual('observed-transaction-method');
     });
 
     it('calls execute with event listeners and is emitting the expected values', (done) => {