Update contract.js #1029
Closed
Update contract.js #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ometimes blockHash is null the second time. You have to wait for the third event
onbjerg
reviewed
Sep 12, 2017
lib/web3/contract.js
Outdated
| @@ -117,8 +117,9 @@ var checkForContractAddress = function(contract, callback){ | |||
| } else { | |||
|
|
|||
| contract._eth.getTransactionReceipt(contract.transactionHash, function(e, receipt){ | |||
| if(receipt && !callbackFired) { | |||
| if(receipt && receipt.blockHash && !callbackFired) { // sometimes blockHash is null the second time - Marco Guarducci <mark.guarducci@gmail.com> | |||
There was a problem hiding this comment.
There's no particular reason you would add this comment. It's already in git and it doesn't clarify anything particularly.
There was a problem hiding this comment.
yes please remove that comment and we can merge that in. web3.js should not be a self advertisement platform ;P
|
@gigirobot |
|
@MarcoGuarducci please remove the comment, so i can merge. |
|
Sorry for delay. I have removed comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes blockHash is null the second time. You have to wait for the third event