Watch improvement #153
Closed
Watch improvement #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the tests, but I want to wait for travis && coveralls before merging. I don't know why, but coveralls is showing me, that coverage dropped to 50%. |
1 similar comment
|
it looks like bignumber.js is incorrectly included somewhere... but I can't find where :/ |
| try { | ||
| request.send(JSON.stringify(payload)); | ||
| } catch(error) { | ||
| throw errors.NoConnection(this.host); |
There was a problem hiding this comment.
it does not mean that it can't connect. This could be also incorrect response.
Conflicts: dist/ethereum-light.js.map dist/ethereum-light.min.js dist/ethereum.js.map dist/ethereum.min.js
|
I've merged 4 of the commits which were fine to master. |
1 similar comment
|
It looks like commit 86c941c is breaking coverage, but I don't know where exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add initial
getFilterLogscheck. add optional callback forwatch.get().One test marek wrote is failing @debris can you please fix it?